[llvm] r196607 - Integrated assembler incorrectly lexes ARM-style comments

Jim Grosbach grosbach at apple.com
Fri Dec 6 14:43:15 PST 2013


Just for consistency with I’d put the initialization in the body of the constructor like the initializer for isAtStartOfLine. Good to commit with that change. Thanks!
-jim
On Dec 6, 2013, at 1:57 PM, David Peixotto <dpeixott at codeaurora.org> wrote:

> Hi Jim,
> 
>>> AsmToken AsmLexer::LexIdentifier() {
>>> +  bool AllowAtInIdentifier =
>>> + !StringRef(MAI.getCommentString()).startswith("@");
>> 
>> Perhaps move this bool to a class variable initialized early so we don't
>> have to query the MAI directly every identifier?
> 
> I've attached a patch that makes this change. Ok to commit?
> 
> <cache-AllowAtInIdentifier.patch>





More information about the llvm-commits mailing list