[llvm] r196607 - Integrated assembler incorrectly lexes ARM-style comments

David Peixotto dpeixott at codeaurora.org
Fri Dec 6 13:57:33 PST 2013


Hi Jim,

> > AsmToken AsmLexer::LexIdentifier() {
> > +  bool AllowAtInIdentifier =
> > + !StringRef(MAI.getCommentString()).startswith("@");
> 
> Perhaps move this bool to a class variable initialized early so we don't
> have to query the MAI directly every identifier?

I've attached a patch that makes this change. Ok to commit?
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cache-AllowAtInIdentifier.patch
Type: application/octet-stream
Size: 1378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131206/baa5722b/attachment.obj>


More information about the llvm-commits mailing list