[llvm] r196228 - Copy input files to test directory.

[Daniel Jasper]

Thanks. Changed in r196255.


On Tue, Dec 3, 2013 at 8:46 AM, Alp Toker <alp at nuanti.com> wrote:

>
> On 03/12/2013 07:35, Daniel Jasper wrote:
>
>> Author: djasper
>> Date: Tue Dec  3 01:35:32 2013
>> New Revision: 196228
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=196228&view=rev
>> Log:
>> Copy input files to test directory.
>>
>> With r196184, llvm-cov creates a new file right next to the input file.
>> However, the Inputs-directory can't simply be assumed to be writable
>> under all build systems.
>>
>> Also, this prevents a new source file from showing up in the source tree
>> if the test aborts before the call to "rm".
>>
>> Modified:
>>      llvm/trunk/test/tools/llvm-cov/llvm-cov.test
>>
>> Modified: llvm/trunk/test/tools/llvm-cov/llvm-cov.test
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/
>> llvm-cov/llvm-cov.test?rev=196228&r1=196227&r2=196228&view=diff
>> ============================================================
>> ==================
>> --- llvm/trunk/test/tools/llvm-cov/llvm-cov.test (original)
>> +++ llvm/trunk/test/tools/llvm-cov/llvm-cov.test Tue Dec  3 01:35:32 2013
>> @@ -1,7 +1,4 @@
>> -RUN: cd %p/Inputs
>> -# "cd" is unsupported in lit internal runner.
>> -REQUIRES: shell
>> -
>> +RUN: cp %p/Inputs/test.* .
>>
>
> The lit integrated shell doesn't support globbing you'll still need the
> REQUIRES.
>
> It might also make sense to precede this with rm -f test.* so the test
> doesn't break in future if the input set changes.
>
> Alp.
>
>
>    RUN: llvm-cov -gcno=test.gcno -gcda=test.gcda
>>   RUN: diff -aub test.cpp.gcov test.cpp.llcov
>>   RUN: rm test.cpp.llcov
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131203/b05243cc/attachment.html>