<div dir="ltr">Thanks. Changed in r196255.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Dec 3, 2013 at 8:46 AM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
On 03/12/2013 07:35, Daniel Jasper wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: djasper<br>
Date: Tue Dec  3 01:35:32 2013<br>
New Revision: 196228<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=196228&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=196228&view=rev</a><br>
Log:<br>
Copy input files to test directory.<br>
<br>
With r196184, llvm-cov creates a new file right next to the input file.<br>
However, the Inputs-directory can't simply be assumed to be writable<br>
under all build systems.<br>
<br>
Also, this prevents a new source file from showing up in the source tree<br>
if the test aborts before the call to "rm".<br>
<br>
Modified:<br>
     llvm/trunk/test/tools/llvm-<u></u>cov/llvm-cov.test<br>
<br>
Modified: llvm/trunk/test/tools/llvm-<u></u>cov/llvm-cov.test<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cov/llvm-cov.test?rev=196228&r1=196227&r2=196228&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/tools/<u></u>llvm-cov/llvm-cov.test?rev=<u></u>196228&r1=196227&r2=196228&<u></u>view=diff</a><br>

==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/tools/llvm-<u></u>cov/llvm-cov.test (original)<br>
+++ llvm/trunk/test/tools/llvm-<u></u>cov/llvm-cov.test Tue Dec  3 01:35:32 2013<br>
@@ -1,7 +1,4 @@<br>
-RUN: cd %p/Inputs<br>
-# "cd" is unsupported in lit internal runner.<br>
-REQUIRES: shell<br>
-<br>
+RUN: cp %p/Inputs/test.* .<br>
</blockquote>
<br></div></div>
The lit integrated shell doesn't support globbing you'll still need the REQUIRES.<br>
<br>
It might also make sense to precede this with rm -f test.* so the test doesn't break in future if the input set changes.<br>
<br>
Alp.<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  RUN: llvm-cov -gcno=test.gcno -gcda=test.gcda<br>
  RUN: diff -aub test.cpp.gcov test.cpp.llcov<br>
  RUN: rm test.cpp.llcov<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</font></span></blockquote></div><br></div>