[patch][pr17918] Use simple section names for COMDAT sections

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Nov 26 17:17:39 PST 2013

On 26 November 2013 18:42, Reid Kleckner <rnk at google.com> wrote:
> Nice, LGTM!  =D
> I assume the Target/X86/X86ISelLowering.cpp changes are unrelated and are
> for a separate commit.

Yes, sorry. Not my day at handling patches. That is the llvm side of
switching to the new mingw abi (pr18034).

> It seems that once we do this, our assembly will no longer be consumable by
> GNU as, which I guess is why you turned on integrated-as for mingw recently.
> Do you see that as a problem, or is gas just hopelessly broken for COFF
> because it can't represent what we're trying to assemble here?

That is correct. I can see no way of creating two sections with the
same name with gas on COFF.


More information about the llvm-commits mailing list