[patch][pr17918] Use simple section names for COMDAT sections
rnk at google.com
Tue Nov 26 15:42:18 PST 2013
Nice, LGTM! =D
I assume the Target/X86/X86ISelLowering.cpp changes are unrelated and are
for a separate commit.
It seems that once we do this, our assembly will no longer be consumable by
GNU as, which I guess is why you turned on integrated-as for mingw
recently. Do you see that as a problem, or is gas just hopelessly broken
for COFF because it can't represent what we're trying to assemble here?
On Tue, Nov 26, 2013 at 3:26 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:
> ccing the correct list and attaching the correct patch this time :-(
> On 26 November 2013 17:57, Rafael Espíndola <rafael.espindola at gmail.com>
> > With the attached patch we use simple names for COMDAT sections (like
> > .text or .bss). This matches the MSVC behavior.
> > When merging it is the COMDAT symbol that is used to decide if two
> > sections should be merged, so there is no point in building a fancy
> > name.
> > This survived a bootstrap on mingw32.
> > Cheers,
> > Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits