[PATCH] Add return to DIType::Verify

Eric Christopher echristo at gmail.com
Tue Nov 26 08:26:54 PST 2013


Ok.
On Nov 26, 2013 4:54 AM, "Renato Golin" <renato.golin at linaro.org> wrote:

> Hi echristo,
>
> Code scanner ran by Sylvestre Ledru got a no_return bug in DebugInfo.cpp.
> Adding the return statements that should be there.
>
>
> http://llvm-reviews.chandlerc.com/D2271
>
> Files:
>   lib/IR/DebugInfo.cpp
>
> Index: lib/IR/DebugInfo.cpp
> ===================================================================
> --- lib/IR/DebugInfo.cpp
> +++ lib/IR/DebugInfo.cpp
> @@ -461,11 +461,11 @@
>    // DIType is abstract, it should be a BasicType, a DerivedType or
>    // a CompositeType.
>    if (isBasicType())
> -    DIBasicType(DbgNode).Verify();
> +    return DIBasicType(DbgNode).Verify();
>    else if (isCompositeType())
> -    DICompositeType(DbgNode).Verify();
> +    return DICompositeType(DbgNode).Verify();
>    else if (isDerivedType())
> -    DIDerivedType(DbgNode).Verify();
> +    return DIDerivedType(DbgNode).Verify();
>    else
>      return false;
>    return true;
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131126/c63967f8/attachment.html>


More information about the llvm-commits mailing list