[PATCH] Add return to DIType::Verify

Renato Golin renato.golin at linaro.org
Tue Nov 26 04:55:14 PST 2013

Hi echristo,

Code scanner ran by Sylvestre Ledru got a no_return bug in DebugInfo.cpp. Adding the return statements that should be there.



Index: lib/IR/DebugInfo.cpp
--- lib/IR/DebugInfo.cpp
+++ lib/IR/DebugInfo.cpp
@@ -461,11 +461,11 @@
   // DIType is abstract, it should be a BasicType, a DerivedType or
   // a CompositeType.
   if (isBasicType())
-    DIBasicType(DbgNode).Verify();
+    return DIBasicType(DbgNode).Verify();
   else if (isCompositeType())
-    DICompositeType(DbgNode).Verify();
+    return DICompositeType(DbgNode).Verify();
   else if (isDerivedType())
-    DIDerivedType(DbgNode).Verify();
+    return DIDerivedType(DbgNode).Verify();
     return false;
   return true;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2271.1.patch
Type: text/x-patch
Size: 634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131126/d15b5b08/attachment.bin>

More information about the llvm-commits mailing list