[llvm] r194527 - delinearization of arrays

Eric Christopher echristo at gmail.com
Wed Nov 13 13:31:28 PST 2013

On Wed, Nov 13, 2013 at 12:15 PM, Sebastian Pop <spop at codeaurora.org> wrote:
> Hi,
> Eric Christopher wrote:
>> To pile on... comments man, comments. Lots and lots of algorithm etc
>> comments.
> The SCEV->delinearize algorithm computes the multiples of SCEV coefficients:
> that is a pattern matching of sub expressions in the stride and base of a SCEV
> corresponding to the computation of a GCD (greatest common divisor) of base and
> stride.
> Could you please indicate in the patch the places where you would like to see
> more comments?

Pretty much...

>> Comments on whatever you're testing in the testcases since
> I think the testcases are pretty explicit about what they are testing: if the
> description I gave in the previous email is not enough, let me know: I can give
> more details.

All of this. Anything you felt you needed to write in that email
should be in the code. Block comments in front of functions, algorithm
descriptions with links, etc.

>> right now if they start failing I'm just going to delete the pass :)
> Just let me know before you do that, and I'll fix the testcases ;-)

A short summary in each testcase of what the various lines mean would be good.


> Thanks,
> Sebastian
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation

More information about the llvm-commits mailing list