[llvm] r194541 - Give folks a reference to some material on the fundamental design

[Sean Silva]

Thanks! Really good choice using this pattern :)

(it's my new favorite C++ pattern; just learned about it like a week ago
when catching up on Sean's GN13 talks)


-- Sean Silva


On Tue, Nov 12, 2013 at 8:51 PM, Chandler Carruth <chandlerc at gmail.com>wrote:

> Author: chandlerc
> Date: Tue Nov 12 19:51:36 2013
> New Revision: 194541
>
> URL: http://llvm.org/viewvc/llvm-project?rev=194541&view=rev
> Log:
> Give folks a reference to some material on the fundamental design
> pattern in use here. Addresses review feedback from Sean (thanks!) and
> others.
>
> Modified:
>     llvm/trunk/include/llvm/IR/PassManager.h
>
> Modified: llvm/trunk/include/llvm/IR/PassManager.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManager.h?rev=194541&r1=194540&r2=194541&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/IR/PassManager.h (original)
> +++ llvm/trunk/include/llvm/IR/PassManager.h Tue Nov 12 19:51:36 2013
> @@ -25,6 +25,13 @@
>  ///   a Function.
>  /// * ModulePassManager must be directly run, runs each pass over the
> Module.
>  ///
> +/// Note that the implementations of the pass managers use concept-based
> +/// polymorphism as outlined in the "Value Semantics and Concept-based
> +/// Polymorphism" talk (or its abbreviated sibling "Inheritance Is The
> Base
> +/// Class of Evil") by Sean Parent:
> +/// *
> http://github.com/sean-parent/sean-parent.github.com/wiki/Papers-and-Presentations
> +/// *
> http://channel9.msdn.com/Events/GoingNative/2013/Inheritance-Is-The-Base-Class-of-Evil
> +///
>
>  //===----------------------------------------------------------------------===//
>
>  #include "llvm/ADT/DenseMap.h"
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131112/65aa4238/attachment.html>