<div dir="ltr">Thanks! Really good choice using this pattern :)<div><br></div><div>(it's my new favorite C++ pattern; just learned about it like a week ago when catching up on Sean's GN13 talks)<div><br></div><div>
<br></div><div>-- Sean Silva</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 12, 2013 at 8:51 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chandlerc<br>
Date: Tue Nov 12 19:51:36 2013<br>
New Revision: 194541<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194541&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=194541&view=rev</a><br>
Log:<br>
Give folks a reference to some material on the fundamental design<br>
pattern in use here. Addresses review feedback from Sean (thanks!) and<br>
others.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/IR/PassManager.h<br>
<br>
Modified: llvm/trunk/include/llvm/IR/PassManager.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManager.h?rev=194541&r1=194540&r2=194541&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManager.h?rev=194541&r1=194540&r2=194541&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/include/llvm/IR/PassManager.h (original)<br>
+++ llvm/trunk/include/llvm/IR/PassManager.h Tue Nov 12 19:51:36 2013<br>
@@ -25,6 +25,13 @@<br>
 ///   a Function.<br>
 /// * ModulePassManager must be directly run, runs each pass over the Module.<br>
 ///<br>
+/// Note that the implementations of the pass managers use concept-based<br>
+/// polymorphism as outlined in the "Value Semantics and Concept-based<br>
+/// Polymorphism" talk (or its abbreviated sibling "Inheritance Is The Base<br>
+/// Class of Evil") by Sean Parent:<br>
+/// * <a href="http://github.com/sean-parent/sean-parent.github.com/wiki/Papers-and-Presentations" target="_blank">http://github.com/sean-parent/sean-parent.github.com/wiki/Papers-and-Presentations</a><br>
+/// * <a href="http://channel9.msdn.com/Events/GoingNative/2013/Inheritance-Is-The-Base-Class-of-Evil" target="_blank">http://channel9.msdn.com/Events/GoingNative/2013/Inheritance-Is-The-Base-Class-of-Evil</a><br>
+///<br>
 //===----------------------------------------------------------------------===//<br>
<br>
 #include "llvm/ADT/DenseMap.h"<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>