[PATCH] cmake: link statically against run-time on windows (use /MT instead of /MD)

Hans Wennborg hans at chromium.org
Tue Nov 12 18:04:23 PST 2013


On Tue, Nov 12, 2013 at 4:30 PM, Alp Toker <alp at nuanti.com> wrote:
> I just noticed it might make sense to do this for /MDd /MTd in _DEBUG as
> well.

Hmm, spontaneously I think this mostly makes sense for release builds,
since that's what gets distributed, and I'd rather stick to the
default for debug builds. I don't really have a strong opinion here,
though.

> Also the MINSIZEREL_INIT cases that slipped in shouldn't be necessary.

OK, I'll remove those.

> llvm_replace_compiler_option() does a word replace so the easier way to
> handle all cases would just be to do the replacement directly, something
> like the following:

I kind of like llvm_replace_compiler_option() though, because it will
add the new option even in cases where the old option didn't exist.

Thanks,
Hans



More information about the llvm-commits mailing list