[PATCH] Avoid illegal integer promotion in X86FastISel
Duncan Exon Smith
dexonsmith at apple.com
Mon Nov 11 18:06:40 PST 2013
Thanks for the review!
On Nov 11, 2013, at 5:19 PM, Eric Christopher <echristo at gmail.com> wrote:
> Might want to elaborate with the actual conditions in the comment.
> Also sentences end in a period.
> +bool FastISel::canFoldAddIntoGEP(const User *GEP, const Value *Add)
> + if (TD.getTypeSizeInBits(GEP->getType()) !=
> + TD.getTypeSizeInBits(Add->getType()))
> + if (isa<Instruction>(Add) &&
> + FuncInfo.MBBMap[cast<Instruction>(Add)->getParent()] != FuncInfo.MBB)
> The indenting doesn't look quite right here.
> Meta: clang-format would have fixed all of these for sure. :)
clang-format agreed with me for these. ;)
> +; RUN: llc %s -O0 -o - | FileCheck %s
> +target triple = "armv7-apple-ios"
> Go ahead and fold the triple into RUN line for all of these.
Take 3 attached. Have another look?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 8096 bytes
Desc: not available
More information about the llvm-commits