[PATCH] Avoid illegal integer promotion in X86FastISel

Duncan Exon Smith dexonsmith at apple.com
Mon Nov 11 18:12:31 PST 2013


On Nov 11, 2013, at 5:31 PM, Eric Christopher <echristo at gmail.com> wrote:

> On Mon, Nov 11, 2013 at 5:30 PM, Chandler Carruth <chandlerc at google.com> wrote:
>> 
>> On Mon, Nov 11, 2013 at 5:27 PM, Eric Christopher <echristo at gmail.com>
>> wrote:
>>> 
>>> Lacking a better answer "tradition!" for llc tests.
>> 
>> 
>> I'm specifically asking if we should start moving to something else.
> 
> Ah. No preference here. Trade-off I see is a) more information in the
> run line, vs b) fewer things in the command line to duplicate.
> 
> -eric

FWIW, I find it clearer when the triple is in the IR — perhaps because of syntax highlighting.  (Went with “tradition!" in my updated patch, though.)



More information about the llvm-commits mailing list