[PATCH] Add a CMake option COMPILER_RT_DEBUG for building runtimes with full debug info.

Alexey Samsonov samsonov at google.com
Tue Oct 22 00:32:01 PDT 2013


  LGTM modulo comment.


================
Comment at: lib/CMakeLists.txt:199
@@ -198,1 +198,3 @@
 
+macro(pythonize_bool var)
+  if (${var})
----------------
Yes, I agree that this macro makes sense. But we may want to make it reusable, so consider:
(a) moving it to somewhere like cmake/Modules/CompilerRTUtils.cmake, with a comment describing its contract (creating a ${var}_PYTHON variable).
(b) calling it close to the place where you define COMPILER_RT_DEBUG option.


http://llvm-reviews.chandlerc.com/D1984

BRANCH
  compiler-rt-debug

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list