[PATCH] Add a CMake option COMPILER_RT_DEBUG for building runtimes with full debug info.

[Peter Collingbourne]

================
Comment at: lib/CMakeLists.txt:199
@@ -198,1 +198,3 @@
 
+macro(pythonize_bool var)
+  if (${var})
----------------
Alexey Samsonov wrote:
> No, I'd like to avoid this. You silently change the value of option COMPILER_RT_DEBUG, so it may have a surprising value if one decides to use it later. I think you may just compare config.compiler_rt_debug to "ON"/"OFF" strings. This approach is already used in LLVM test suite - look for config.llvm_use_intel_jitevents attribute.
The issue is that the CMake language considers a number of strings to be true -- see http://www.cmake.org/Wiki/CMake/Language_Syntax#CMake_supports_boolean_variables.  I've changed this to use a different variable for Python.

================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:222
@@ -222,1 +221,3 @@
+  kernel_timeval tv;
+  internal_memset(&tv, 0, sizeof(tv));
   internal_syscall(__NR_gettimeofday, &tv, 0);
----------------
Alexey Samsonov wrote:
> Please commit this as a separate change.
Done.


http://llvm-reviews.chandlerc.com/D1984