[llvm] r192275 - Remove some old filters from the x86 disassembler table builder.

[Craig Topper]

I don't know yet if we can get rid of them completely, but I'm certainly
going to try. If I can't, I think a bit in the td files is a good idea.


On Tue, Oct 8, 2013 at 10:13 PM, Chris Lattner <clattner at apple.com> wrote:

>
> On Oct 8, 2013, at 10:02 PM, Craig Topper <craig.topper at gmail.com> wrote:
>
> > Author: ctopper
> > Date: Wed Oct  9 00:02:29 2013
> > New Revision: 192275
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=192275&view=rev
> > Log:
> > Remove some old filters from the x86 disassembler table builder.
>
> Do you think these filters can eventually go away completely?  If not,
> would it make sense to move these to be a bit expressed in the .td file
> instead of a random list like this?
>
> -Chris
>
> >
> > Modified:
> >    llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp
> >
> > Modified: llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp?rev=192275&r1=192274&r2=192275&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp (original)
> > +++ llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp Wed Oct  9
> 00:02:29 2013
> > @@ -531,11 +531,6 @@ RecognizableInstr::filter_ret Recognizab
> >
> >   // Special cases.
> >
> > -  if (Name.find("PCMPISTRI") != Name.npos && Name != "PCMPISTRI")
> > -    return FILTER_WEAK;
> > -  if (Name.find("PCMPESTRI") != Name.npos && Name != "PCMPESTRI")
> > -    return FILTER_WEAK;
> > -
> >   if (Name.find("MOV") != Name.npos && Name.find("r0") != Name.npos)
> >     return FILTER_WEAK;
> >   if (Name.find("MOVZ") != Name.npos && Name.find("MOVZX") == Name.npos
> &&
> > @@ -546,7 +541,6 @@ RecognizableInstr::filter_ret Recognizab
> >   if (Name == "PUSH64i16"         ||
> >       Name == "MOVPQI2QImr"       ||
> >       Name == "VMOVPQI2QImr"      ||
> > -      Name == "MOV64ri64i32"      ||
> >       Name == "VMASKMOVDQU64"     ||
> >       Name == "VEXTRACTPSrr64")
> >     return FILTER_WEAK;
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131008/c6217364/attachment.html>