<div dir="ltr">I don't know yet if we can get rid of them completely, but I'm certainly going to try. If I can't, I think a bit in the td files is a good idea.</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, Oct 8, 2013 at 10:13 PM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com" target="_blank">clattner@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Oct 8, 2013, at 10:02 PM, Craig Topper <<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>> wrote:<br>
<br>
> Author: ctopper<br>
> Date: Wed Oct  9 00:02:29 2013<br>
> New Revision: 192275<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=192275&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=192275&view=rev</a><br>
> Log:<br>
> Remove some old filters from the x86 disassembler table builder.<br>
<br>
Do you think these filters can eventually go away completely?  If not, would it make sense to move these to be a bit expressed in the .td file instead of a random list like this?<br>
<br>
-Chris<br>
<br>
><br>
> Modified:<br>
>    llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp<br>
><br>
> Modified: llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp?rev=192275&r1=192274&r2=192275&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp?rev=192275&r1=192274&r2=192275&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp (original)<br>
> +++ llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp Wed Oct  9 00:02:29 2013<br>
> @@ -531,11 +531,6 @@ RecognizableInstr::filter_ret Recognizab<br>
><br>
>   // Special cases.<br>
><br>
> -  if (Name.find("PCMPISTRI") != Name.npos && Name != "PCMPISTRI")<br>
> -    return FILTER_WEAK;<br>
> -  if (Name.find("PCMPESTRI") != Name.npos && Name != "PCMPESTRI")<br>
> -    return FILTER_WEAK;<br>
> -<br>
>   if (Name.find("MOV") != Name.npos && Name.find("r0") != Name.npos)<br>
>     return FILTER_WEAK;<br>
>   if (Name.find("MOVZ") != Name.npos && Name.find("MOVZX") == Name.npos &&<br>
> @@ -546,7 +541,6 @@ RecognizableInstr::filter_ret Recognizab<br>
>   if (Name == "PUSH64i16"         ||<br>
>       Name == "MOVPQI2QImr"       ||<br>
>       Name == "VMOVPQI2QImr"      ||<br>
> -      Name == "MOV64ri64i32"      ||<br>
>       Name == "VMASKMOVDQU64"     ||<br>
>       Name == "VEXTRACTPSrr64")<br>
>     return FILTER_WEAK;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig
</div>