[PATCH] AArch64 Neon scalar integer to floating-point convert instructions

mcrosier at codeaurora.org mcrosier at codeaurora.org
Tue Oct 8 08:49:58 PDT 2013


Thanks, Tim.  I will address this in all my patches.

 Chad

> Just one minor point, but it seems to be cropping up a lot:
>
> +multiclass NeonI_Scalar2SameMisc_SD_size<bit u, bit size_high, bits<5>
> opcode,
> +                                         string asmop>
> +{
>
> I think we format TableGen in pretty much the same way as C++, so
> braces on the end of a line. I know I made a pass through the whole
> backend making this consistent near the beginning (I preferred the
> extra spacing too).
>
> Other than that it these two look good.
>
> Cheers.
>
> Tim.
>





More information about the llvm-commits mailing list