[PATCH] AArch64 Neon scalar integer to floating-point convert instructions

Tim Northover t.p.northover at gmail.com
Tue Oct 8 08:41:32 PDT 2013


Just one minor point, but it seems to be cropping up a lot:

+multiclass NeonI_Scalar2SameMisc_SD_size<bit u, bit size_high, bits<5> opcode,
+                                         string asmop>
+{

I think we format TableGen in pretty much the same way as C++, so
braces on the end of a line. I know I made a pass through the whole
backend making this consistent near the beginning (I preferred the
extra spacing too).

Other than that it these two look good.

Cheers.

Tim.



More information about the llvm-commits mailing list