[PATCH] improve arm machine code (make -verify-machineinstrs happier)

Renato Golin renato.golin at linaro.org
Thu Oct 3 15:54:44 PDT 2013

On 3 October 2013 18:49, Quentin Colombet <qcolombet at apple.com> wrote:

> Could you add a test case for each case you are fixing (possibly in the
> same test file)?

Yes, that'd make a lot clearer on what kind of bug you're hitting and how
you're fixing them.

I'd prefer a specific test on each patch, so that it gets bundled and helps
future patch reviewers to understand the context.

Regarding the patches, without looking at an example, it's hard to
understand what you're trying to fix. Still, the addOperand() patch seems
straight-forward, and the tail call patch looks correct, though it'd be
good to see it in action on a test. But it's not easy to spot what the
optimizeSelect patch is trying to fix.

Also, in addition to a test on each patch, would be good to get better
commit descriptions, especially on the optimizeSelect patch.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131003/9aa747ec/attachment.html>

More information about the llvm-commits mailing list