[PATCH] improve arm machine code (make -verify-machineinstrs happier)

Matthias Braun mbraun at apple.com
Thu Oct 3 16:00:15 PDT 2013

I added testcases and resend in separate emails this minute. Here’s also a revised version of the optimizeSelect with a more verbose description:

ARM: optimizeSelect has to consider the previous register

optimizeSelect folds (predicated) copy instructions, it must not ignore
the original register class of the operand when replacing the register
with the copies dest register.


On Oct 3, 2013, at 3:54 PM, Renato Golin <renato.golin at linaro.org> wrote:

> On 3 October 2013 18:49, Quentin Colombet <qcolombet at apple.com> wrote:
> Could you add a test case for each case you are fixing (possibly in the same test file)?
> Yes, that'd make a lot clearer on what kind of bug you're hitting and how you're fixing them.
> I'd prefer a specific test on each patch, so that it gets bundled and helps future patch reviewers to understand the context.
> Regarding the patches, without looking at an example, it's hard to understand what you're trying to fix. Still, the addOperand() patch seems straight-forward, and the tail call patch looks correct, though it'd be good to see it in action on a test. But it's not easy to spot what the optimizeSelect patch is trying to fix.
> Also, in addition to a test on each patch, would be good to get better commit descriptions, especially on the optimizeSelect patch.
> cheers,
> --renato

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131003/a3032d58/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ARM-optimizeSelect-has-to-consider-the-previous-regi.patch
Type: application/octet-stream
Size: 3994 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131003/a3032d58/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131003/a3032d58/attachment-0001.html>

More information about the llvm-commits mailing list