[llvm] r191343 - Move LTO support library to a component, allowing it to be tested

Tom Roeder tmroeder at google.com
Fri Sep 27 17:05:08 PDT 2013


On Fri, Sep 27, 2013 at 4:37 PM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> On 27 September 2013 19:22, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>> On 27 September 2013 16:37, Tom Roeder <tmroeder at google.com> wrote:
>>> Hi Richard,
>>>
>>> Thanks for catching that. The LTO library code was including
>>> llvm/CodeGen/CommandFlags.h, which was also getting included in
>>> binaries like llc, hence the multiple definitions.
>
> Reading the patch I think you meant copy and pasting, not #including.
>
> The patch is OK, but could you move the ExportedSymbols bits to a new patch?
>
> Cheers,
> Rafael

Sorry for the confusion. Yes, that's right.

Here's a patch that doesn't include the ExportedSymbols bit.

Thanks,

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lto_options.patch
Type: application/octet-stream
Size: 26246 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130927/8c814fe7/attachment.obj>


More information about the llvm-commits mailing list