[llvm] r191343 - Move LTO support library to a component, allowing it to be tested

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Sep 27 16:37:38 PDT 2013


On 27 September 2013 19:22, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> On 27 September 2013 16:37, Tom Roeder <tmroeder at google.com> wrote:
>> Hi Richard,
>>
>> Thanks for catching that. The LTO library code was including
>> llvm/CodeGen/CommandFlags.h, which was also getting included in
>> binaries like llc, hence the multiple definitions.

Reading the patch I think you meant copy and pasting, not #including.

The patch is OK, but could you move the ExportedSymbols bits to a new patch?

Cheers,
Rafael




More information about the llvm-commits mailing list