[PATCH] Don't localize globals that may serve as leak checker roots.
samsonov at google.com
Wed Sep 25 11:38:49 PDT 2013
On Wed, Sep 25, 2013 at 10:21 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:
> > Don't we care about valgrind's leak detector any more? :)
> We do, but I would still put this behind a clang -fsanitize=valgrind
> option that is document to disable optimizations that confuse valgrind
> and for now just adds this metadata.
Well, I haven't added isLeakCheckerRoot() function - I think it's already
used in GlobalOpt pass to disable some optimizations that may confuse leak
e.g. it doesn't remove global variable that may be a leak checker root and
its value is
That said, if you want the optimization to remain, I can change the patch
to make sure
we disable it only if ASan is turned on (that would be a bit more
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits