[PATCH] Don't localize globals that may serve as leak checker roots.
kcc at google.com
Wed Sep 25 11:19:23 PDT 2013
On Wed, Sep 25, 2013 at 10:15 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:
> On 25 September 2013 13:31, Reid Kleckner <rnk at google.com> wrote:
> > I missed any earlier discussion about this. Don't we want to keep this
> > optimization, even if it's a real corner case that fires once in a blue
> > moon? isLeakCheckerRoot() doesn't check any flags to see if any of the
> > sanitizers are on.
> I agree. Wouldn't it be better for clang to attach metadata to a
> global variable to say it is a GC root? That way the optimization is
> only disabled when using a sanitizer.
Don't we care about valgrind's leak detector any more? :)
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits