[PATCH] Don't localize globals that may serve as leak checker roots.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Sep 25 11:15:17 PDT 2013

On 25 September 2013 13:31, Reid Kleckner <rnk at google.com> wrote:
> I missed any earlier discussion about this.  Don't we want to keep this
> optimization, even if it's a real corner case that fires once in a blue
> moon?  isLeakCheckerRoot() doesn't check any flags to see if any of the
> sanitizers are on.

I agree. Wouldn't it be better for clang to attach metadata to a
global variable to say it is a GC root? That way the optimization is
only disabled when using a sanitizer.


More information about the llvm-commits mailing list