MC parser and PPC variants on constants

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Aug 27 13:12:52 PDT 2013


LGTM.

Thanks,
Rafael


On 27 August 2013 16:04, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> On Tue, Aug 27, 2013 at 03:05:53PM -0400, Rafael EspĂ­ndola wrote:
>> + virtual const MCExpr *ApplyModifierToExpr(const MCExpr *E,
>>
>> lowercase please.
>>
>> + const MCExpr *newE
>>
>> should be NewE
>>
>>
>> Can you add a test with the error case that Ulrich suggested
>> (123 at got)? LGTM with these changes.
>
> Attached.
>
> Joerg
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list