MC parser and PPC variants on constants

Joerg Sonnenberger joerg at britannica.bec.de
Tue Aug 27 13:04:07 PDT 2013


On Tue, Aug 27, 2013 at 03:05:53PM -0400, Rafael EspĂ­ndola wrote:
> + virtual const MCExpr *ApplyModifierToExpr(const MCExpr *E,
> 
> lowercase please.
> 
> + const MCExpr *newE
> 
> should be NewE
> 
> 
> Can you add a test with the error case that Ulrich suggested
> (123 at got)? LGTM with these changes.

Attached.

Joerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mc-ppc.diff
Type: text/x-diff
Size: 5279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130827/d8792e7c/attachment.diff>


More information about the llvm-commits mailing list