[PATCH] Change representation of dllexport/dllimport

[Nico Rieck]

  Oh, you meant adding them to GlobalValue::VisibilityTypes? I don't really like referring to dllexport/dllimport as visibilities, especially not dllimport. Though in the end I care more about getting this in. I agree that there's a certain duplication in the IR reader/writer. Regarding combining them, I wonder what the ARM compiler does. Browsing through their reference, they seem to support dllexport/dllimport using ELF (and also visibility). I can't find anything in the docs about issues combining them though. While dllexport must always have default visibility, dllimport could be any.


================
Comment at: test/CodeGen/X86/dllimport-x86_64.ll:27
@@ +26,3 @@
+; FAST:  movq  __imp_fun(%rip), [[R:%[a-z]{3}]]
+; FAST:  callq *[[R]]
+  call void @fun()
----------------
Reid Kleckner wrote:
> Should this be FAST-NEXT: or have some other way to avoid matching one of the calls from below?
Yeah, would be better.


http://llvm-reviews.chandlerc.com/D1110