[PATCH] Change representation of dllexport/dllimport

Reid Kleckner rnk at google.com
Wed Aug 14 10:07:28 PDT 2013


  I still feel strongly that dllexport and dllimport should be new visibility values.

  Is there any compelling reason to support a combination of dllimport/dllexport + visibility(hidden/internal/protected)?  If not, I don't see any reason to make that representable in IR.


================
Comment at: test/CodeGen/X86/dllimport-x86_64.ll:27
@@ +26,3 @@
+; FAST:  movq  __imp_fun(%rip), [[R:%[a-z]{3}]]
+; FAST:  callq *[[R]]
+  call void @fun()
----------------
Should this be FAST-NEXT: or have some other way to avoid matching one of the calls from below?

================
Comment at: test/CodeGen/X86/dllimport.ll:31
@@ +30,3 @@
+; FAST:  movl  __imp__fun, [[R:%[a-z]{3}]]
+; FAST:  calll *[[R]]
+  call void @fun()
----------------
ditto


http://llvm-reviews.chandlerc.com/D1110



More information about the llvm-commits mailing list