Fix bug in linear regressions on linear version numbers

Daniel Dunbar daniel at zuster.org
Fri Aug 9 17:14:08 PDT 2013


LGTM.

 - Daniel


On Fri, Aug 9, 2013 at 3:46 PM, Chris Matthews <chris.matthews at apple.com>wrote:

> Fix a bug (which I introduced) in handling of linear regressions on linear
> version numbers.  This resolves the “unsupported operand type(s) for -:
> ‘tuple’ and ‘tuple’” server error when rendering linear regressions.
>
> --- a/lnt/server/ui/views.py
> +++ b/lnt/server/ui/views.py
> @@ -547,10 +547,11 @@ def v4_graph():
>              dates = [data_date[1] for data_date in datapoints]
>
>              metadata = {"label":point_label}
> -            # on simple revisions use rev number for x else start from
> -            # 0
> +
> +            # When we can, map x-axis to revisions, but when that is too
> hard
> +            # use the position of the sample instead.
>              rev_x = convert_revision(point_label)
> -            x = rev_x if len(rev_x)==1 else pos
> +            x = rev_x[0] if len(rev_x)==1 else pos
>
>              values = [v*normalize_by for v in data]
>              min_index,min_value = min(enumerate(values))
>
>
> Chris Matthews
> chris.matthews at apple.com
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130809/4bdbf30f/attachment.html>


More information about the llvm-commits mailing list