<div dir="ltr">LGTM.<div><br></div><div> - Daniel</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 9, 2013 at 3:46 PM, Chris Matthews <span dir="ltr"><<a href="mailto:chris.matthews@apple.com" target="_blank">chris.matthews@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Fix a bug (which I introduced) in handling of linear regressions on linear version numbers.  This resolves the “unsupported operand type(s) for -: ‘tuple’ and ‘tuple’” server error when rendering linear regressions.<div>
<br></div><div><div>--- a/lnt/server/ui/views.py</div><div>+++ b/lnt/server/ui/views.py</div><div>@@ -547,10 +547,11 @@ def v4_graph():</div><div>             dates = [data_date[1] for data_date in datapoints]</div><div> </div>
<div>             metadata = {"label":point_label}</div><div>-            # on simple revisions use rev number for x else start from</div><div>-            # 0</div><div>+            </div><div>+            # When we can, map x-axis to revisions, but when that is too hard</div>
<div>+            # use the position of the sample instead.</div><div>             rev_x = convert_revision(point_label)</div><div>-            x = rev_x if len(rev_x)==1 else pos</div><div>+            x = rev_x[0] if len(rev_x)==1 else pos</div>
<div> </div><div>             values = [v*normalize_by for v in data]</div><div>             min_index,min_value = min(enumerate(values))</div><div></div></div></div><br><div style="word-wrap:break-word"><div><div></div><div>

<div style="text-indent:0px;letter-spacing:normal;text-align:start;text-transform:none;white-space:normal;word-wrap:break-word;word-spacing:0px"><div style="text-indent:0px;letter-spacing:normal;text-align:start;text-transform:none;white-space:normal;word-wrap:break-word;word-spacing:0px">
<div style="text-indent:0px;letter-spacing:normal;text-align:start;text-transform:none;white-space:normal;word-wrap:break-word;word-spacing:0px"><br><span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:start;font-style:normal;display:inline!important;font-weight:normal;float:none;line-height:normal;text-transform:none;white-space:normal;font-family:Helvetica;word-spacing:0px">Chris Matthews</span><br style="line-height:normal;text-indent:0px;letter-spacing:normal;text-align:start;font-variant:normal;text-transform:none;font-style:normal;white-space:normal;font-family:Helvetica;font-weight:normal;word-spacing:0px">
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:start;font-style:normal;display:inline!important;font-weight:normal;float:none;line-height:normal;text-transform:none;white-space:normal;font-family:Helvetica;word-spacing:0px"><a href="mailto:chris.matthews@apple.com" target="_blank">chris.matthews@apple.com</a></span><br style="line-height:normal;text-indent:0px;letter-spacing:normal;text-align:start;font-variant:normal;text-transform:none;font-style:normal;white-space:normal;font-family:Helvetica;font-weight:normal;word-spacing:0px">
<br style="line-height:normal;text-indent:0px;letter-spacing:normal;text-align:start;font-variant:normal;text-transform:none;font-style:normal;white-space:normal;font-family:Helvetica;font-weight:normal;word-spacing:0px">
</div></div></div>
</div>
<br></div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>