MC parser and PPC variants on constants

Rafael EspĂ­ndola rafael.espindola at
Sat Jul 20 16:44:53 PDT 2013

On 19 July 2013 17:59, Joerg Sonnenberger <joerg at> wrote:
> On Fri, Jul 19, 2013 at 05:31:35PM -0400, Rafael EspĂ­ndola wrote:
>> virtual const MCExpr *ApplyModifierToExpr(const MCExpr *E,
>> +                                            MCSymbolRefExpr::VariantKind) {
>> Start function name with a lowercase. Please define this virtual
>> function out of line.
> It's named like the target-independent function.

I would probably still follow the llvm style. Other functions in the
target asm parser do.


More information about the llvm-commits mailing list