[PATCH] Expose option EnableGlobalMerge from ARMTargetMachine

[Weiming Zhao]

Hi Bill,

Oh, I see. I will try using ParseCommandLineOptions. 
Thanks for the suggestion.

Thanks,
Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

-----Original Message-----
From: Bill Wendling [mailto:wendling at apple.com] 
Sent: Friday, July 12, 2013 1:18 PM
To: weimingz at codeaurora.org
Cc: llvm-commits
Subject: Re: [PATCH] Expose option EnableGlobalMerge from ARMTargetMachine

On Jul 11, 2013, at 6:08 PM, Weiming Zhao <weimingz at codeaurora.org> wrote:

> Hi,
>  
> This patch exposes EnableGlobalMerge to other libs/drivers they
enable/disable the pass.
> For example, RenderScript compiler driver may turn it off in some cases. 
> 
> Please help to review the patch.
>  
Hi Weiming,

I don't understand this patch. What are you attempting to do with this
patch? How will you use the command line option once it's not 'static'? The
whole thing about command line options is that they will be present when you
link in the associated library. If what you're trying to do is enable or
disable this pass from a driver, you should probably figure out a different
method other than having the driver set a command line variable (which, by
the way, are not guaranteed to stick around). For instance, you may be able
to add the appropriate command line option to what is passed to
`cl::ParseCommandLineOptions'.

-bw