[llvm] r185832 - Create files with the correct permission instead of changing it afterwards.

[Rafael Espíndola]

>> +error_code openFileForRead(const Twine &Name, int &ResultFD) {
>> +  int OpenFlags = O_RDONLY;
>> +#ifdef O_BINARY
>> +  OpenFlags |= O_BINARY; // Open input file in binary mode on win32.
>> +#endif
>
> Are there no files that you would ever want to be opened as text on Windows using this interface?

ever I don't know, but there are none now. It is easy to add an
argument when/if the need shows up.

> Other than that, LGTM (which means nothing, of course).
>
> --
> Stephen Checkoway


Cheers,
Rafael