[llvm] r185832 - Create files with the correct permission instead of changing it afterwards.

[Stephen Checkoway]

On Jul 16, 2013, at 10:58 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> Rebased patches attached.

> +error_code openFileForRead(const Twine &Name, int &ResultFD) {
> +  int OpenFlags = O_RDONLY;
> +#ifdef O_BINARY
> +  OpenFlags |= O_BINARY; // Open input file in binary mode on win32.
> +#endif

Are there no files that you would ever want to be opened as text on Windows using this interface?

Other than that, LGTM (which means nothing, of course).

-- 
Stephen Checkoway