[llvm] r186392 - ARM: implement ldrex, strex and clrex intrinsics

[Justin Holewinski]

It looks reasonable to me. Thanks for catching this! Im surprised it hasnt shown up earlier.

-----Original Message-----
From: Tim Northover [t.p.northover at gmail.com]
Received: Tuesday, 16 Jul 2013, 5:54am
To: Tim Northover [tnorthover at apple.com]; Justin Holewinski [jholewinski at nvidia.com]
CC: llvm-commits [llvm-commits at cs.uiuc.edu]
Subject: Re: [llvm] r186392 - ARM: implement ldrex, strex and clrex intrinsics

Hi Justin,

Sorry about this. Noticed it when debugging and unexpectedly found
that "X" was a known global variable. I didn't mean to commit it (and
certainly not with this).

Does it look reasonable or do you want me to revert that part?

Tim.

>     llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp
> [...]
> Modified: llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp?rev=186392&r1=186391&r2=186392&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp (original)
> +++ llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp Tue Jul 16 04:46:55 2013
> @@ -37,7 +37,7 @@ bool NVPTXAllocaHoisting::runOnFunction(
>  }
>
>  char NVPTXAllocaHoisting::ID = 1;
> -RegisterPass<NVPTXAllocaHoisting>
> +static RegisterPass<NVPTXAllocaHoisting>
>  X("alloca-hoisting", "Hoisting alloca instructions in non-entry "
>                       "blocks to the entry block");

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130716/5c20de0d/attachment.html>