<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text -->
<style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style></head>
<body>
<body style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:11pt; color:black"><span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:11pt; color:black">It looks reasonable to me. Thanks for catching this! Im surprised it hasnt shown up earlier.<br><br><span style="color:black">-----Original Message----- <br><b>From:</b> Tim Northover [t.p.northover@gmail.com]<br><b>Received:</b> Tuesday, 16 Jul 2013, 5:54am<br><b>To:</b> Tim Northover [tnorthover@apple.com]; Justin Holewinski [jholewinski@nvidia.com]<br><b>CC:</b> llvm-commits [llvm-commits@cs.uiuc.edu]<br><b>Subject:</b> Re: [llvm] r186392 - ARM: implement ldrex, strex and clrex intrinsics<br><br></span></span>
<DIV>
<HR>
</DIV>
<DIV>This email message is for the sole use of the intended recipient(s) and may
contain confidential information. Any unauthorized review, use, disclosure
or distribution is prohibited. If you are not the intended recipient,
please contact the sender by reply email and destroy all copies of the original
message. </DIV>
<DIV>
<HR>
</DIV>
<P></P>
</body>
<font size="2"><div class="PlainText">Hi Justin,<br>
<br>
Sorry about this. Noticed it when debugging and unexpectedly found<br>
that "X" was a known global variable. I didn't mean to commit it (and<br>
certainly not with this).<br>
<br>
Does it look reasonable or do you want me to revert that part?<br>
<br>
Tim.<br>
<br>
> llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp<br>
> [...]<br>
> Modified: llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp?rev=186392&r1=186391&r2=186392&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp?rev=186392&r1=186391&r2=186392&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp (original)<br>
> +++ llvm/trunk/lib/Target/NVPTX/NVPTXAllocaHoisting.cpp Tue Jul 16 04:46:55 2013<br>
> @@ -37,7 +37,7 @@ bool NVPTXAllocaHoisting::runOnFunction(<br>
> }<br>
><br>
> char NVPTXAllocaHoisting::ID = 1;<br>
> -RegisterPass<NVPTXAllocaHoisting><br>
> +static RegisterPass<NVPTXAllocaHoisting><br>
> X("alloca-hoisting", "Hoisting alloca instructions in non-entry "<br>
> "blocks to the entry block");<br>
</div></font>
</body>
</html>