[PATCH] ARM: fix application of de morgan's law

David Majnemer david.majnemer at gmail.com
Sat Jun 29 15:46:34 PDT 2013


CC'ing Bob Wilson

It seems like Bob introduced this check in r141370, he would probably best
understand what was supposed to happen here.

-- 
David Majnemer


On Sat, Jun 29, 2013 at 3:19 PM, Tim Northover <t.p.northover at gmail.com>wrote:

> > This would inadvertently enable tail calls when they should not be.
>
> > -  if (!EnableARMTailCalls && !Subtarget->supportsTailCall())
> > +  if (!EnableARMTailCalls || !Subtarget->supportsTailCall())
>
> Are you sure this isn't the intended behaviour? It seems to come down
> to whether -arm-tail-calls means "do a tail call if you think it's
> safe" or "do a tail call even if you think it's unsafe". None of the
> surrounding documentation seems clear on the intent, but either
> interpretation could be useful for different people.
>
> Tim.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130629/bc68f737/attachment.html>


More information about the llvm-commits mailing list