<div dir="ltr"><div style>CC'ing Bob Wilson</div><div><br></div>It seems like Bob introduced this check in r141370, he would probably best understand what was supposed to happen here.<div><br></div><div style>-- </div>
<div style>David Majnemer</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jun 29, 2013 at 3:19 PM, Tim Northover <span dir="ltr"><<a href="mailto:t.p.northover@gmail.com" target="_blank">t.p.northover@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">> This would inadvertently enable tail calls when they should not be.<br>
<br>
</div><div class="im">> -  if (!EnableARMTailCalls && !Subtarget->supportsTailCall())<br>
> +  if (!EnableARMTailCalls || !Subtarget->supportsTailCall())<br>
<br>
</div>Are you sure this isn't the intended behaviour? It seems to come down<br>
to whether -arm-tail-calls means "do a tail call if you think it's<br>
safe" or "do a tail call even if you think it's unsafe". None of the<br>
surrounding documentation seems clear on the intent, but either<br>
interpretation could be useful for different people.<br>
<br>
Tim.<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>