[PATCH] ARM: fix thumb1 nop decoding

Renato Golin renato.golin at linaro.org
Fri Jun 21 10:13:51 PDT 2013


On 21 June 2013 18:00, Tim Northover <tnorthover at apple.com> wrote:

> Because it’s not the official NOP hint, and reassembling a disassembled
> instruction should produce the same bits.
>

That's a good point.


Besides, you can’t just go around inventing assembly syntax like that even
> if another NOP didn’t exist — for a start why should “mov r8, r8” be NOP
> but not “mov r9, r9”?
>

This is not invented, it's in ARM ARM as the pre-UAL NOP (H.3).


The patch looks good to me.
>

To me too.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130621/3374d24f/attachment.html>


More information about the llvm-commits mailing list