please review - llvm test-suite patch

[reed kotler]

HI Daniel,

We need the Multisource/UnitTests to test all the Mips32/Mips16 floating 
point interoperability.

This is a real crazy quilt design that evolved over time that I 
inherited from gcc. I actually came up with a better way to do all of 
that that does not have any of this complexity but my management 
insisted that I first implement the gcc scheme.

If the compiler can see all the code then it can cheat and not generate 
the stubs.

Basically Mips32 code does not know anything about Mips16 code.

There are only issues when there are values usually passed or returned 
in floating point registers accord to the Mips32 ABI.

When in Mips16 mode, you can't execute any floating point instructions 
or access floating point registers.

In that mode there is more or less a soft float with run time support 
written in code compiled in Mips32 mode.

Anyway there are lots of cases to test and pic and static are much 
different in some areas too.

When you compile Mips16 code that returns floating point values or has 
floating point parameters that are normally passed in floating point 
registers OR that calls external functions of unknown type (Mips32 or 
Mips16), then there are various stubs or predefined library functions 
that must be created/called.

Anyway.. I need multiple physical source files to test this completely.

Reed



On 06/17/2013 10:59 AM, Daniel Dunbar wrote:
> Hi Reed,
>
> Does MultiSource/UnitTests really make sense? Generally we want most 
> of the code in the test suite to be cross platform, so I would hope 
> that any architecture specific tests are limited to checking very 
> specific features, and are well suited to the 
> directory-full-of-single-file-tests model.
>
> Other than that, the patch looks fine to me.
>
>  - Daniel
>
>
>
>
> On Sat, Jun 8, 2013 at 10:47 PM, reed kotler <rkotler at mips.com 
> <mailto:rkotler at mips.com>> wrote:
>
>     This patch is to allow areas in SingleSource and MultiSource for
>     Mips specific tests to be added to UnitTests in those areas.
>
>     Some example tests are included in the patch.
>
>     I have tested with x86 and Mips test suites and for Mips with lnt.
>
>     Am rerunning all tests this weekend.
>
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130617/7f7740f0/attachment.html>