please review - llvm test-suite patch

Daniel Dunbar daniel at zuster.org
Mon Jun 17 10:59:20 PDT 2013


Hi Reed,

Does MultiSource/UnitTests really make sense? Generally we want most of the
code in the test suite to be cross platform, so I would hope that any
architecture specific tests are limited to checking very specific features,
and are well suited to the directory-full-of-single-file-tests model.

Other than that, the patch looks fine to me.

 - Daniel




On Sat, Jun 8, 2013 at 10:47 PM, reed kotler <rkotler at mips.com> wrote:

> This patch is to allow areas in SingleSource and MultiSource for Mips
> specific tests to be added to UnitTests in those areas.
>
> Some example tests are included in the patch.
>
> I have tested with x86 and Mips test suites and for Mips with lnt.
>
> Am rerunning all tests this weekend.
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130617/a19c9bf1/attachment.html>


More information about the llvm-commits mailing list