[PATCH] Add host feature detection for Qualcomm CPUs

Tobias Grosser grosser at google.com
Mon Jun 10 14:05:59 PDT 2013


Ups, I sent it to the wrong mailing list. :-(


On Mon, Jun 10, 2013 at 1:35 PM, James Molloy <James.Molloy at arm.com> wrote:

> Hi Tobi,
>
> [cc llvm-commits]
>
> I don't understand why you need to replicate all that - why can't you just
> change:
>
> if (Implementer == "0x41") // ARM Ltd.
>
> To:
>
> if (Implementer == "0x41" || Implementer == "0x31")
>
> ?
>
> It looks like the feature strings will be the same - and in fact we
> grabbed them straight from the Linux kernel source which returns the same
> strings for ARM-like CPUs (QC or ARM).


I was unsure if the feature strings will be the same. However, I just
looked into the Linux code and it seems it always emits the same feature
strings for both targets. Here an updated patch.

OK to commit?

Cheers,
Tobias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130610/e0896d6b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-host-CPU-feature-detection-for-Qualcomm-CPUs.patch
Type: application/octet-stream
Size: 896 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130610/e0896d6b/attachment.obj>


More information about the llvm-commits mailing list