[PATCH] Add host feature detection for Qualcomm CPUs

[James Molloy]

Hi Tobi,

[cc llvm-commits]

I don't understand why you need to replicate all that - why can't you just change:

if (Implementer == "0x41") // ARM Ltd.

To:

if (Implementer == "0x41" || Implementer == "0x31")

?

It looks like the feature strings will be the same - and in fact we grabbed them straight from the Linux kernel source which returns the same strings for ARM-like CPUs (QC or ARM).

Cheers,

James

________________________________________
From: Tobias Grosser [grosser at google.com]
Sent: 10 June 2013 21:18
To: LLVMdev at cs.uiuc.edu
Cc: James Molloy
Subject: [PATCH] Add host feature detection for Qualcomm CPUs

Hi,

I would like to add host feature detection for Qualcomm CPUs. The implementation models
the feature detection for ARM CPUs. Is this OK to commit?

Thanks,
Tobi

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.