[PATCH] ARM FastISel fix sext/zext fold

JF Bastien jfb at google.com
Mon Jun 10 16:09:19 PDT 2013


> Did you mean:
>>
>> for (unsigned i = 0, e = array_lengthof(**FoldableExtends); i < e; ++i) {
>>
>> ? It's defined in ADT/STLExtras.h.
>>
>
> Indeed I did. My grepping failed to find this, but found a lot of code
> that looked like what I wrote :-)
> I'll use that when I check-in.
>

Actually:
warning: template argument uses local type '<anonymous struct at

/usr/local/google/home/jfb/sandbox/llvm/llvm/lib/Target/ARM/ARMFastISel.cpp:2889:16>'
[-Wlocal-type-template-args]
  for (unsigned i = 0, e = array_lengthof(FoldableExtends);
                           ^~~~~~~~~~~~~~

Would you rather have this in an anonymous namespace, or keep the previous
code? I quite like function locals for readability. (also: silly template
rules, grr).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130610/e3dae804/attachment.html>


More information about the llvm-commits mailing list