[PATCH] [lld][LayoutPass] Split buildFollowOnTable for readability.

Rui Ueyama ruiu at google.com
Tue May 14 09:54:53 PDT 2013


Thanks. Addressed in r181804.


On Mon, May 13, 2013 at 11:11 PM, Sean Silva <silvas at purdue.edu> wrote:

>
>
> ================
> Comment at: lld/trunk/lib/Passes/LayoutPass.cpp:152
> @@ +151,3 @@
> +      return true;
> +    if ((*atom).size() != 0)
> +      // TODO: print warning that an impossible layout is being desired
> by the
> ----------------
> Sean Silva wrote:
> > You can simplify this to just  `atom->size()`
> I mean, replace `(*atom).size()` by `atom->size()`
>
>
> http://llvm-reviews.chandlerc.com/D790
>
> COMMIT
>   http://llvm-reviews.chandlerc.com/rL181749
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130514/824b5ed5/attachment.html>


More information about the llvm-commits mailing list