[PATCH] [lld] Add comments to InputFiles::searchLibraries() arguments.

[Chandler Carruth]

On Thu, May 9, 2013 at 3:00 AM, Rui Ueyama <ruiu at google.com> wrote:

> Sorry for not following that common practice. I'll follow that rule next
> time.
>
> llvm-commits@ has been CC'ed from the beginning, but I couldn't find the
> original mail in the mailing list archive. At the time when I send the
> first patch, I was already a member of the list. No idea why it was not
> delivered as expected.
>

Very weird...

>
>
> On Wed, May 8, 2013 at 5:45 PM, Chandler Carruth <chandlerc at google.com>wrote:
>
>> In general, once you mail a patch out for pre-commit review, you should
>> wait until it finishes even if it was pretty trivial. Just ping to get
>> reviews faster.
>>
>> Also, I didn't even get the mail for this -- it seems not to have gone to
>> the full commit list originally. So it's not surprising that it took a
>> while to get review. I have comments, but I'll make them on the actual
>> commit.
>>
>>
>> On Thu, May 9, 2013 at 1:49 AM, Rui Ueyama <ruiu at google.com> wrote:
>>
>>> I'm going to commit this, because this is really trivial change so it
>>> can be reviewed after committed.
>>>
>>>
>>> On Thu, Apr 25, 2013 at 5:17 AM, Rui Ueyama <ruiu at google.com> wrote:
>>>
>>>> Hi kledzik,
>>>>
>>>> http://llvm-reviews.chandlerc.com/D726
>>>>
>>>> Files:
>>>>   lib/Core/Resolver.cpp
>>>>
>>>> Index: lib/Core/Resolver.cpp
>>>> ===================================================================
>>>> --- lib/Core/Resolver.cpp
>>>> +++ lib/Core/Resolver.cpp
>>>> @@ -196,7 +196,11 @@
>>>>        StringRef undefName = undefAtom->name();
>>>>        // load for previous undefine may also have loaded this undefine
>>>>        if (!_symbolTable.isDefined(undefName)) {
>>>> -        _inputFiles.searchLibraries(undefName, true, true, false,
>>>> *this);
>>>> +        _inputFiles.searchLibraries(undefName,
>>>> +                                    true,   // searchSharedLibs
>>>> +                                    true,   // searchArchives
>>>> +                                    false,  // dataSymbolOnly
>>>> +                                    *this);
>>>>        }
>>>>      }
>>>>      // search libraries for overrides of common symbols
>>>> @@ -209,10 +213,13 @@
>>>>          const Atom *curAtom = _symbolTable.findByName(tentDefName);
>>>>          assert(curAtom != nullptr);
>>>>          if (const DefinedAtom* curDefAtom =
>>>> dyn_cast<DefinedAtom>(curAtom)) {
>>>> -          if (curDefAtom->merge() == DefinedAtom::mergeAsTentative ) {
>>>> +          if (curDefAtom->merge() == DefinedAtom::mergeAsTentative) {
>>>>              // Still tentative definition, so look for override.
>>>> -            _inputFiles.searchLibraries(tentDefName, searchSharedLibs,
>>>> -                                        searchArchives, true, *this);
>>>> +            _inputFiles.searchLibraries(tentDefName,
>>>> +                                        searchSharedLibs,
>>>> +                                        searchArchives,
>>>> +                                        true,  // dataSymbolOnly
>>>> +                                        *this);
>>>>            }
>>>>          }
>>>>        }
>>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130509/18b4d489/attachment.html>