<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, May 9, 2013 at 3:00 AM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank" class="cremed">ruiu@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sorry for not following that common practice. I'll follow that rule next time.<div><br></div><div>llvm-commits@ has been CC'ed from the beginning, but I couldn't find the original mail in the mailing list archive. At the time when I send the first patch, I was already a member of the list. No idea why it was not delivered as expected.</div>
</div></blockquote><div><br></div><div style>Very weird... </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">
</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 8, 2013 at 5:45 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank" class="cremed">chandlerc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">In general, once you mail a patch out for pre-commit review, you should wait until it finishes even if it was pretty trivial. Just ping to get reviews faster.<div>
<br></div><div>Also, I didn't even get the mail for this -- it seems not to have gone to the full commit list originally. So it's not surprising that it took a while to get review. I have comments, but I'll make them on the actual commit.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Thu, May 9, 2013 at 1:49 AM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank" class="cremed">ruiu@google.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
<div dir="ltr">I'm going to commit this, because this is really trivial change so it can be reviewed after committed.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Apr 25, 2013 at 5:17 AM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank" class="cremed">ruiu@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi kledzik,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D726" target="_blank" class="cremed">http://llvm-reviews.chandlerc.com/D726</a><br>
<br>
Files:<br>
lib/Core/Resolver.cpp<br>
<br>
Index: lib/Core/Resolver.cpp<br>
===================================================================<br>
--- lib/Core/Resolver.cpp<br>
+++ lib/Core/Resolver.cpp<br>
@@ -196,7 +196,11 @@<br>
StringRef undefName = undefAtom->name();<br>
// load for previous undefine may also have loaded this undefine<br>
if (!_symbolTable.isDefined(undefName)) {<br>
- _inputFiles.searchLibraries(undefName, true, true, false, *this);<br>
+ _inputFiles.searchLibraries(undefName,<br>
+ true, // searchSharedLibs<br>
+ true, // searchArchives<br>
+ false, // dataSymbolOnly<br>
+ *this);<br>
}<br>
}<br>
// search libraries for overrides of common symbols<br>
@@ -209,10 +213,13 @@<br>
const Atom *curAtom = _symbolTable.findByName(tentDefName);<br>
assert(curAtom != nullptr);<br>
if (const DefinedAtom* curDefAtom = dyn_cast<DefinedAtom>(curAtom)) {<br>
- if (curDefAtom->merge() == DefinedAtom::mergeAsTentative ) {<br>
+ if (curDefAtom->merge() == DefinedAtom::mergeAsTentative) {<br>
// Still tentative definition, so look for override.<br>
- _inputFiles.searchLibraries(tentDefName, searchSharedLibs,<br>
- searchArchives, true, *this);<br>
+ _inputFiles.searchLibraries(tentDefName,<br>
+ searchSharedLibs,<br>
+ searchArchives,<br>
+ true, // dataSymbolOnly<br>
+ *this);<br>
}<br>
}<br>
}<br>
</blockquote></div><br></div>
<br></div></div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>